[PATCH] D45473: CodeGen: Don't try to canonicalize Unix-style paths in CodeView debug info.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:117-125
+  // If this is a Unix-style path, just use it as is. Don't try to canonicalize
+  // it textually because one of the path components could be a symlink.
+  if (!Dir.empty() && Dir[0] == '/') {
+    Filepath = Dir;
+    if (Dir.back() != '/')
+      Filepath += '/';
+    Filepath += Filename;
----------------
Shouldn't we instead just use something like `LLVM_ON_WIN32` etc?


https://reviews.llvm.org/D45473