[PATCH] D45154: [x86] Model the direction flag (DF) separately from the rest of EFLAGS.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added inline comments.


================
Comment at: llvm/lib/Target/X86/Disassembler/X86Disassembler.cpp:273
+      // And then provide a zero terminating entry.
+      0,
   };
----------------
craig.topper wrote:
> Is this even needed? Was someone trying to protect against a trailing comma in the macro expansion? Which we now have outside...
I assumed this was trying to create a null terminator.

I thought we made trailing commas a no-op for these things so that stuff like this was OK?


================
Comment at: llvm/lib/Target/X86/X86RegisterInfo.td:523
 }
+def DFCCR : RegisterClass<"X86", [i32], 32, (add DF)> {
+  let CopyCost = -1;  // Don't allow copying of status registers.
----------------
craig.topper wrote:
> I feel like CCR is a bad name here since that should mean "condition code register" and DF is not that.
Any better naming ideas?


Repository:
  rL LLVM

https://reviews.llvm.org/D45154