[PATCH] D45396: [DebugInfo] Create merged locations for instructions other than calls

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Do you have the stats on this change in terms of line table size increase?

Which callers use Instruction::applyMergedLocation versus DILocation::getMergedLocation directly?



================
Comment at: lib/IR/DebugInfo.cpp:678-679
                                       const DILocation *LocB) {
-  setDebugLoc(DILocation::getMergedLocation(LocA, LocB, this));
+  bool GenerateLocation = true;
+  setDebugLoc(DILocation::getMergedLocation(LocA, LocB, GenerateLocation));
 }
----------------
Maybe have the API use an enum instead of a bool (so callers pass the enum & are inherently readable), rather than relying on callers to name the parameter for readability?


https://reviews.llvm.org/D45396