[PATCH] D45457: [sanitizer] Split Symbolizer/StackTraces from core RTSanitizerCommon

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 14:29:07 PDT 2018


cryptoad created this revision.
Herald added subscribers: Sanitizers, llvm-commits, delcypher, krytarowski, mgorny, kubamracek, srhines.

Host symbolizer & stacktraces related code in their own RT:
`RTSanitizerCommonSymbolizer`, which is "libcdep" by nature. Symbolizer &
stacktraces specific code that used to live in common files is moved to a new
file `sanitizer_symbolizer_report.cc` as is.

The purpose of this is the enforce a separation between code that relies on
symbolization and code that doesn't. This saves the inclusion of spurious code
due to the interface functions with default visibility, and the extra data
associated.

The following sanitizers makefiles were modified & tested locally:

- dfsan: doesn't require the new symbolizer RT
- esan: requires it
- hwasan: requires it
- lsan: requires it
- msan: requires it
- safestack: doesn't require it
- xray: doesn't require it
- tsan: requires it
- ubsan: requires it
- ubsan_minimal: doesn't require it
- scudo: requires it (but not for Fuchsia that has a minimal runtime)

Currently ironing out some Android issues.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D45457

Files:
  lib/asan/CMakeLists.txt
  lib/asan/tests/CMakeLists.txt
  lib/esan/CMakeLists.txt
  lib/hwasan/CMakeLists.txt
  lib/lsan/CMakeLists.txt
  lib/msan/CMakeLists.txt
  lib/sanitizer_common/CMakeLists.txt
  lib/sanitizer_common/sanitizer_common.cc
  lib/sanitizer_common/sanitizer_common_libcdep.cc
  lib/sanitizer_common/sanitizer_linux.cc
  lib/sanitizer_common/sanitizer_linux_libcdep.cc
  lib/sanitizer_common/sanitizer_posix.cc
  lib/sanitizer_common/sanitizer_symbolizer_report.cc
  lib/sanitizer_common/tests/CMakeLists.txt
  lib/scudo/CMakeLists.txt
  lib/tsan/CMakeLists.txt
  lib/tsan/go/buildgo.sh
  lib/tsan/tests/CMakeLists.txt
  lib/ubsan/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45457.141741.patch
Type: text/x-patch
Size: 36594 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180409/a8c23415/attachment.bin>


More information about the llvm-commits mailing list