[PATCH] D44808: Fix lib.exe detection when running within MSVC toolchain

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: tools/llvm-ar/llvm-ar.cpp:61
 
-USAGE: llvm-ranlib <archive-file>
+USAGE: {0} <archive-file>
 
----------------
I'm sorry that my previous comment was vague. I don't think you need to change this and


================
Comment at: tools/llvm-ar/llvm-ar.cpp:73
 
-USAGE: llvm-ar [options] [relpos] [count] <archive-file> [members]...
+USAGE: {0} [options] [relpos] [count] <archive-file> [members]...
 
----------------
this.


================
Comment at: tools/llvm-ar/llvm-ar.cpp:113-115
+  if (Stem.find_lower("ranlib") != StringRef::npos)
+    outs() << formatv(RanlibHelp, Stem);
+  else if (Stem.find_lower("ar") != StringRef::npos)
----------------
I meant you should replace find with find_lower (and I didn't mean that you should use formatv.)


Repository:
  rL LLVM

https://reviews.llvm.org/D44808