[PATCH] D45427: [AArch64][AsmParser] Unify code for parsing Neon/SVE vectors.

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Indeed, nice cleanup. I think we discussed this earlier and it's a much welcome change, to merge NEON and SVE parsing.

Apart from the error message text, NFC. With Florian's comments, LGTM, thanks!

I'll let @fhahn approve when he's ready.



================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:1575
   static std::unique_ptr<AArch64Operand>
-  CreateReg(unsigned RegNum, RegKind Kind, unsigned ElementWidth,
-            SMLoc S, SMLoc E, MCContext &Ctx) {
+  CreateVectorReg(unsigned RegNum, RegKind Kind, unsigned ElementWidth,
+                  SMLoc S, SMLoc E, MCContext &Ctx) {
----------------
Maybe an assert making sure the arguments are compatible with vector registers?


https://reviews.llvm.org/D45427