[PATCH] D45379: [LoopInterchange] Ignore debug intrinsics during legality checks.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopInterchange.cpp:82
+template <typename T>
+static auto skipDebugIntrinsics(iterator_range<T> Iter)
+    -> decltype(make_filter_range(Iter, isDebugIntrinsic)) {
----------------
vsk wrote:
> aprantl wrote:
> > This adapter should really be available in BasicBlock.h or somewhere more accessible if it doesn't exist already. Could you move it there (or elsewhere appropriate) and add a doxygen comment?
> + 1, I think having `iterator_range<iterator> instructions()` and `... instructions_nodbg()` in BasicBlock would be nice.
Ok great, I will move it there. Do you think we should just have a member function `instructionsNodbg()` or a function taking an instruction iterator and returning a filtered iterator? It's just a question how we want to compose it with things like reverse


https://reviews.llvm.org/D45379