[PATCH] D45435: [CodeGen/AccelTable] Don't emit zero-CU name indexes
Pavel Labath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 9 07:42:17 PDT 2018
labath added inline comments.
================
Comment at: lib/CodeGen/AsmPrinter/AccelTable.cpp:370
Asm->emitInt32(CompUnitCount);
+ assert(CompUnitCount > 0);
Asm->OutStreamer->AddComment("Header: local type unit count");
----------------
JDevlieghere wrote:
> Why not put this at the top like a pre-condition? Maybe also add a message?
No particular reason. I agree it looks better at the top.
Repository:
rL LLVM
https://reviews.llvm.org/D45435
More information about the llvm-commits
mailing list