[PATCH] D45360: [MC][TableGen] Add optional libpfm counter names for ProcResUnits.

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

Thanks Andrea,

In https://reviews.llvm.org/D45360#1061551, @andreadb wrote:

> Nice patch.
>
> Would it be difficult to have a single string table for all the PfmIssueCounters defined by the scheduling models?
>
> The compressed table comes with the downside that it requires an extra mapping between processor resource IDs and indices to the string table. That mapping could be stored somewhere in the "ExtraInfo" table.
>
> I hope this makes sense.


Makes sense, this is similar to how scheduling info is stored.
I guess that what we gain from doing this  also depends on whether we really do split ExtraInfo to a separate target that only llvm-mca and llvm-exegesis link. If that's the case, then not compressing is not a big deal.

> Overall, the patch looks good. I am also okay if you want to commit this patch first, and then improve the design in a follow-up patch.

I'd rather do it in a separate patch to keep matters separate if you don't mind.


Repository:
  rL LLVM

https://reviews.llvm.org/D45360