[PATCH] D45435: [CodeGen/AccelTable] Don't emit zero-CU name indexes

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 06:27:53 PDT 2018


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Other than the inline comment this LGTM



================
Comment at: lib/CodeGen/AsmPrinter/AccelTable.cpp:370
   Asm->emitInt32(CompUnitCount);
+  assert(CompUnitCount > 0);
   Asm->OutStreamer->AddComment("Header: local type unit count");
----------------
Why not put this at the top like a pre-condition? Maybe also add a message? 


Repository:
  rL LLVM

https://reviews.llvm.org/D45435





More information about the llvm-commits mailing list