[PATCH] D45433: [llvm-mca] Add the ability to mark regions of code for analysis (PR36875)

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 03:58:44 PDT 2018


andreadb created this revision.
andreadb added reviewers: RKSimon, courbet, spatel, gbedwell.
Herald added subscribers: tschuett, mgorny.

This patch teaches llvm-mca how to parse code comments in search for special "markers" used to select regions of code.

Example:

1. LLVM-MCA-START My Code Region ....
2. LLVM-MCA-END

The MCAsmLexer now delegates to an object of class MCACommentParser (i.e. an `AsmCommentConsumer`) the parsing of code comments to search for begin/end code region markers.

A comment starting with substring "LLVM-MCA-START" marks the beginning of a new region of code.
A comment starting with substring "LLVM-MCA-END" marks the end of the last region.

This implementation doesn't allow regions to overlap. Each region can have a optional description; internally, each region is described by a range of source code locations (SMLoc).

MCInst objects are added to a region R only if the source location for the MCInst is in the range of locations specified by R.

By default, the tool allocates an implicit "Default" code region which contains every source location.
See new tests llvm-mca-marker-*.s for a few examples.

How this affect the report generated by the tool?
-------------------------------------------------

A new Backend object is created for every region. So, the analysis is conducted on every parsed code region.
The final report is the union of the reports generated for every code region. Note that empty regions are skipped.

Special "[#] Code Region - ..." strings are used in the report to mark the portion which is specific to a code region only. For example, see llvm-mca-markers-5.s.

Please let me know if okay to commit.

Thanks
-Andrea


https://reviews.llvm.org/D45433

Files:
  test/tools/llvm-mca/X86/llvm-mca-markers-1.s
  test/tools/llvm-mca/X86/llvm-mca-markers-2.s
  test/tools/llvm-mca/X86/llvm-mca-markers-3.s
  test/tools/llvm-mca/X86/llvm-mca-markers-4.s
  test/tools/llvm-mca/X86/llvm-mca-markers-5.s
  test/tools/llvm-mca/X86/llvm-mca-markers-6.s
  test/tools/llvm-mca/X86/llvm-mca-markers-7.s
  tools/llvm-mca/CMakeLists.txt
  tools/llvm-mca/CodeRegion.cpp
  tools/llvm-mca/CodeRegion.h
  tools/llvm-mca/SourceMgr.h
  tools/llvm-mca/llvm-mca.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45433.141609.patch
Type: text/x-patch
Size: 20439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180409/1160fdf6/attachment.bin>


More information about the llvm-commits mailing list