[PATCH] D43578: -ftime-report switch support in Clang

[Andrew V. Tischenko via Phabricator via llvm-commits]

avt77 added inline comments.


================
Comment at: lib/Lex/Pragma.cpp:44
+#include "llvm/ADT/StringSwitch.h"
+#include "llvm/Pass.h"
 #include "llvm/Support/Compiler.h"
----------------
mzolotukhin wrote:
> Why do we need "Pass.h" here?
Because we need llvm::TimePassesIsEnabled.


================
Comment at: lib/Lex/Pragma.cpp:89
                                             bool IgnoreNull) const {
+  llvm::NamedRegionTimer NRT("clangparser22", "PP Find Handler", GroupName,
+                             GroupDescription, llvm::TimePassesIsEnabled);
----------------
mzolotukhin wrote:
> What does the number 22 mean (and other similar numbers in the names)?
I renamed all such names but in fact it's only a simple timer ID that's why we could use any name here.


================
Comment at: lib/Lex/Pragma.cpp:137
                                          PragmaIntroducerKind Introducer) {
+  llvm::NamedRegionTimer NRT("pppragma", "Handle Pragma Directive", GroupName,
+                             GroupDescription, llvm::TimePassesIsEnabled);
----------------
mzolotukhin wrote:
> Typo in "pppragma"?
No, stays for PreProcessor Pragma


https://reviews.llvm.org/D43578