[PATCH] D44885: [RISCV] Expand function call to auipc and jalr

[Shiva Chen via Phabricator via llvm-commits]

shiva0217 added inline comments.


================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVELFObjectWriter.cpp:29
+                               unsigned Type) const override {
+    return true;
+  }
----------------
asb wrote:
> Is this universally true, or true only for  ELF::R_RISCV_PCREL_LO12_I?
It seems that gcc always emit relocations with symbols which could observe by readelf object files. So it's probably universally true. I changed the comment as "Return true to preserve symbol with relocations instead of section plus offset". Is it ok?  


Repository:
  rL LLVM

https://reviews.llvm.org/D44885