[PATCH] D45362: [IRCE] Relax restriction on collected range checks
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 8 22:05:08 PDT 2018
mkazantsev added a comment.
Hi Sam,
Please make a patch and submit it to review, I don't have a good answer on top of my head but maybe you are right. We might still have some obsolete restrictions in this code that can now be lifted.
================
Comment at: lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:316
+ auto IsLoopInvariant = [&SE, L](Value *V) {
+ return SE.isLoopInvariant(SE.getSCEV(V), L);
};
----------------
samparker wrote:
> Do we really need a lambda for a single statement?
Well, it's used twice, so let's leave it as is
https://reviews.llvm.org/D45362
More information about the llvm-commits
mailing list