[PATCH] D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests

Joe Loser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 8 15:01:02 PDT 2018


jloser added a comment.

In https://reviews.llvm.org/D44411#1056374, @EricWF wrote:

> Have you verified that we're not losing test coverage here? That is, are you sure we still have tests for the rvalue overloads in other test files?


Yep. These containers already have tests for inserts with rvalues. No loss in test coverage here.


https://reviews.llvm.org/D44411





More information about the llvm-commits mailing list