[PATCH] D45140: [Support] Change std::sort to llvm::sort in response to r327219

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 18:48:34 PDT 2018


mgrang added a comment.

In https://reviews.llvm.org/D45140#1054514, @jordan_rose wrote:

> I'm a little disappointed that `llvm::sort` got added without providing a range-based variant, the way we did for `llvm::none_of` and `llvm::find` and others. (I wasn't watching the original thread.) I see no problem with these changes, though!


@jordan_rose Thanks for your suggestion. Are there instances in llvm where we perform range-based sorting? I see that std has an experimental range-based sort (std::experimental::ranges::sort) which I don't see being used in llvm.

Also what should be the semantics of a range-based shuffle sort? Will it just shuffle the given range? Or should it shuffle the entire container but just sort the range?


Repository:
  rL LLVM

https://reviews.llvm.org/D45140





More information about the llvm-commits mailing list