[PATCH] D44874: [X86] Change std::sort to llvm::sort in response to r327219

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 18:38:10 PDT 2018


mgrang added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:38877
       SplitString(StringRef(ConstraintsStr).substr(5), AsmPieces, ",");
-      array_pod_sort(AsmPieces.begin(), AsmPieces.end());
+      llvm::sort(AsmPieces.begin(), AsmPieces.end());
       if (clobbersFlagRegisters(AsmPieces))
----------------
craig.topper wrote:
> StringRef should be pod so why did this need to change?
Seems to have been an oversight in replacing these. I have fixed it in my latest patch. Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D44874





More information about the llvm-commits mailing list