[PATCH] D45118: Initial propototype for mergin (custom) debug sections with DWARF format.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Since this looks like a straightforward implementation to copy DWARF sections to an output, I think I'm fine with this change overall as long as wasm guys are fine. But I feel more comfortable if you document the debug story somewhere (as a separate doc or as a comment). Currently it is too terse that readers of the code can't tell what is decided and what's not.



================
Comment at: wasm/InputFiles.cpp:305
+  }
+  case WASM_SYMBOL_TYPE_SECTION: {
+    if (Sym.Info.SectionCode != WASM_SEC_CUSTOM)
----------------
Is this a new enum? Looks like it doesn't exist at the moment.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45118