[PATCH] D45352: [LLVM-C] Move DIBuilder Bindings For Block Scopes

Harlan Haskins via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 16:03:09 PDT 2018


harlanhaskins requested changes to this revision.
harlanhaskins added a comment.
This revision now requires changes to proceed.

LGTM after that one small go style change.



================
Comment at: bindings/go/llvm/dibuilder.go:210
 		diScope.C,
-		name,
-		linkageName,
+		name, C.size_t(len(f.Name)),
+		linkageName, C.size_t(len(f.LinkageName)),
----------------
Can you put these on the next line?


https://reviews.llvm.org/D45352





More information about the llvm-commits mailing list