[PATCH] D45379: [LoopInterchange] Ignore debug intrinsics during legality checks.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 15:58:50 PDT 2018


vsk added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopInterchange.cpp:82
+template <typename T>
+static auto skipDebugIntrinsics(iterator_range<T> Iter)
+    -> decltype(make_filter_range(Iter, isDebugIntrinsic)) {
----------------
aprantl wrote:
> This adapter should really be available in BasicBlock.h or somewhere more accessible if it doesn't exist already. Could you move it there (or elsewhere appropriate) and add a doxygen comment?
+ 1, I think having `iterator_range<iterator> instructions()` and `... instructions_nodbg()` in BasicBlock would be nice.


https://reviews.llvm.org/D45379





More information about the llvm-commits mailing list