[PATCH] D45342: [DebugInfo] Examine all uses of isDebugValue() for debug instructions.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/CodeGen/MachineBasicBlock.h:893
 inline IterT skipDebugInstructionsForward(IterT It, IterT End) {
-  while (It != End && It->isDebugValue())
+  while (It != End && It->isDebugInstr())
     It++;
----------------
It might be interesting so look at the uses and see if this shouldn't instead test for isMetaInstruction.


================
Comment at: lib/CodeGen/AsmPrinter/DbgValueHistoryCalculator.cpp:239
+      if (MI.isDebugLabel())
+	continue;
+
----------------
indentation


================
Comment at: lib/CodeGen/ScheduleDAGInstrs.cpp:768
+      continue;
+    }
     SUnit *SU = MISUnitMap[&MI];
----------------
LLVM usually doesn't use braces around a single statement.


Repository:
  rL LLVM

https://reviews.llvm.org/D45342