[PATCH] D45303: shadowcallstack: Make runtime tests compatible with aarch64.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/test/shadowcallstack/libc_support.h:31
+      "mov x5, xzr\n"
+      "mov x8, #222\n"  // mmap
+      "svc #0\n"
----------------
use NR_MMAP?


================
Comment at: compiler-rt/test/shadowcallstack/minimal_runtime.h:28
+#elif defined(__aarch64__)
+  __asm__ __volatile__("mov x18, %0" ::"r"(stack));
+#else
----------------
Why do you need anything above this line to not use libc? Why does it matter if they clobber x18 before it is set? It looks like scs_mmap_anon, for example, could be just libc mmap.


https://reviews.llvm.org/D45303