[PATCH] D45355: [SelectionDAG] Fix return calling convention in expansion of ?MULO

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 12:40:37 PDT 2018


efriedma added a comment.

Can you make a testcase for some in-tree target affected by this bug?  From what I understand, thumbebv6-linux-gnueabi should be affected by this issue.



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3622
              "Ret value is a collection of constituent nodes holding result.");
-      BottomHalf = Ret.getOperand(0);
-      TopHalf = Ret.getOperand(1);
+      if(DAG.getDataLayout().isLittleEndian()) {
+        // Same as above.
----------------
Whitespace.


Repository:
  rL LLVM

https://reviews.llvm.org/D45355





More information about the llvm-commits mailing list