[PATCH] D45108: [InstCombine] Get rid of select of bittest (PR36950 / PR17564)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineSelect.cpp:407
+/// instructions, but we got rid of select.
+/// https://rise4fun.com/Alive/uiH
+static Instruction *foldSelectICmpAndAnd(Type *SelType, const ICmpInst *IC,
----------------
lebedev.ri wrote:
> spatel wrote:
> > IIRC, we don't want Alive links in the LLVM source (but Alive links in commit messages and bug reports are fine) - avoid any potential legal/licensing problems. 
> First time i'm reading about this, will remove.
> Source only, it's ok in tests?
No, we don't want the links in tests either because those are included in the greater body of 'LLVM source'.
So you should remove the existing link from the test file too. It's fine to paste the Alive proof text if you want though.
 
There's no official guideline about this AFAIK, but there probably should be. I'm certain that I also wanted to include an Alive link in some patch long ago and was told not to, but I can't find that thread.

I'm not an expert, so if you want better answers, it's best to ask on llvm-dev.


Repository:
  rL LLVM

https://reviews.llvm.org/D45108