[PATCH] D45375: [ELF] - Introduce synthetic file for linker script symbols.

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added a comment.

I like the general direction.



================
Comment at: ELF/LTO.cpp:166
+        !(DR->Section == nullptr &&
+          (isa<SyntheticFile>(Sym->File) || Sym->File->isElf()));
 
----------------
Can we now say what the comment says: !isa<BitcodeFile>(Sym->File)?


================
Comment at: ELF/ScriptParser.cpp:267
 void ScriptParser::readDefsym(StringRef Name) {
+  std::string Loc = getCurrentLocation();
   Expr E = readExpr();
----------------
Why this change?


https://reviews.llvm.org/D45375