[PATCH] D36351: [lld][ELF] Add profile guided section layout

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added inline comments.


================
Comment at: ELF/CallGraphSort.cpp:49
+
+#include "llvm/Support/MathExtras.h"
+
----------------
Dead include.


================
Comment at: ELF/Driver.cpp:602
+    uint64_t &C = Config->CallGraphProfile[std::make_pair(FromSym, ToSym)];
+    C = SaturatingAdd(C, Count);
+  }
----------------
Bigcheese wrote:
> espindola wrote:
> > This means that we supports having duplicated symbol edges. Is there a reason for that? If not please change this to report an error on duplicated edges.
> > 
> This makes it easier to create input.  For instance you can cat together profiles from different runs.
Fair enough. Please add a testcase showing that behavior. 



https://reviews.llvm.org/D36351