[PATCH] D45331: [StackProtector] Ignore certain intrinsics when calculating sspstrong heuristic.

[Matt Davis via Phabricator via llvm-commits]

mattd added a comment.

In https://reviews.llvm.org/D45331#1059258, @timshen wrote:

> > In the future we should rely on TargetTransformInfo::isLoweredToCall, but as of
> >  now that routine considers all intrinsics as not being lowerable.
>
> Can we just add lifetime intrinsics support into TTI::isLoweredToCall() ? Will it break other things? If it's doable, then the stackprotector just needs to call isLoweredToCall().


I'm hesitant to modify isLoweredToCall right now, as I think it will need more work to decide whether a particular intrinsic is lowerable.  For now, I figure we just put a 
check to avoid counting the lifetime/debug intrinsics  in this heuristic.  It seems checks similar to the ones in this patch are pretty common throughout the codebase, at least for ignoring debug intrinsics.


https://reviews.llvm.org/D45331