[PATCH] D45343: [InstCombine] Always remove null check before free

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 06:56:36 PDT 2018


lebedev.ri added inline comments.


================
Comment at: test/Transforms/InstCombine/null-check-free.ll:1
+; RUN: opt < %s -instcombine -S | FileCheck %s
+
----------------
lebedev.ri wrote:
> Please use `llvm/utils/update_test_checks.py`.
> Also, the test is incomplete, `@nullcheckfree` is only listed in the check line, but it's not defined anywhere,
> (You need to upload the diff as compared to the git master/svn trunk, not as compared to the previous diff)
The usual comment at the top is missing though:
```
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
```


https://reviews.llvm.org/D45343





More information about the llvm-commits mailing list