[PATCH] D45020: [mips] Accept 32-bit offsets for lb and lbu commands

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 6 06:41:59 PDT 2018


atanasyan added a comment.

In https://reviews.llvm.org/D45020#1056816, @sdardis wrote:

> I don't think this is quite the correct approach, especially if you're going to be implementing support for 64-bit pointers with those instructions, as we would need to modify the existing lb64 and friends to be available to the AsmParser with a different set of operands.
>
> Instead, we should use the 'mem' operand for the lb and lbu instructions. That will allow the parser to match larger offsets than those instructions permit.


Thanks for review. I will provide another patch soon.


Repository:
  rL LLVM

https://reviews.llvm.org/D45020





More information about the llvm-commits mailing list