[PATCH] D45343: [InstCombine] Always remove null check before free

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

I don't think you intended to add `mypatch.patch`

Also, i suspect ideally there should be an explanation of why "null check before free is currently removed only when we are optimizing for size." and then why "This patch removes that limitation."



================
Comment at: test/Transforms/InstCombine/null-check-free.ll:1
+; RUN: opt < %s -instcombine -S | FileCheck %s
+
----------------
Please use `llvm/utils/update_test_checks.py`.
Also, the test is incomplete, `@nullcheckfree` is only listed in the check line, but it's not defined anywhere,
(You need to upload the diff as compared to the git master/svn trunk, not as compared to the previous diff)


https://reviews.llvm.org/D45343