[PATCH] D45350: COFF: Process /merge flag as we create output sections.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 20:16:32 PDT 2018


ruiu added inline comments.


================
Comment at: lld/COFF/Writer.cpp:218-219
+
+  Chunk *FirstPdata = nullptr;
+  Chunk *LastPdata;
 };
----------------
It is not obvious why only .pdata is handled in a special way. Can you add a comment?


================
Comment at: lld/COFF/Writer.cpp:406
+      Name = I->second;
+    auto &Sec = Sections[Name];
+    if (!Sec) {
----------------
auto -> OutputSection *


https://reviews.llvm.org/D45350





More information about the llvm-commits mailing list