[PATCH] D45346: [LLVM-C] Audit Inline Assembly APIs for Consistency

[Robert Widmann via Phabricator via llvm-commits]

CodaFi added inline comments.


================
Comment at: include/llvm-c/Core.h:684
+LLVMValueRef LLVMGetInlineAsm(LLVMTypeRef Ty,
+                              char *AsmString, char *Constraints,
+                              LLVMBool HasSideEffects, LLVMBool IsAlignStack,
----------------
whitequark wrote:
> whitequark wrote:
> > I think this should be `const char *AsmString, size_t AsmStringSize, const char *Constraints, size_t ConstraintsSize`.
> Or rather `const char *AsmString, size_t AsmStringLen, const char *Constraints, size_t ConstraintsLen`.
Aha, good catch.


https://reviews.llvm.org/D45346