[PATCH] D45197: Change which file we print when a symbol cannot be ordered

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 19:01:08 PDT 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Writer.cpp:1080
+  };
+  for (Symbol *Sym : Symtab->getSymbols())
+    if (!Sym->isLazy())
----------------
Please add a comment saying that we add all symbols including local symbols so we have two loops.


https://reviews.llvm.org/D45197





More information about the llvm-commits mailing list