[PATCH] D44184: Write DWARF data into WASM object file

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:52
+  // Where the section header ends (without custom section name).
+  uint64_t PayloadOffset;
+  // Where the contents of the section starts.
----------------
yurydelendik wrote:
> dschuff wrote:
> > If we always reserve 5 bytes for the section size, couldn't the payload offset always be size offset + 5? We don't rewrite those in MC, right?
> Would you like to express it as invariant / debug only field, and add related asserts in the code?
I think are you right Derek.  Its not strictly related to this change but i guess we never really needed `ContentsOffset`.


Repository:
  rL LLVM

https://reviews.llvm.org/D44184