[PATCH] D44184: Write DWARF data into WASM object file

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:488
+    }
+    Relocs->second.push_back(Rec);
+    return;
----------------
Can you just write these 6 lines as:

```CustomSectionsRelocations[FixupSectionName].push_back(Rec);```


================
Comment at: tools/yaml2obj/yaml2wasm.cpp:439
+      if (!CustomSection->Name.startswith(".debug_")) {
+	llvm_unreachable("not yet implemented (only for debug sections)");
+	return 1;
----------------
Indentation looks strange here and a few other places too.  git clang-format?


Repository:
  rL LLVM

https://reviews.llvm.org/D44184