[PATCH] D43907: [llvm-cov] Implement -ignore-source-regex= option for excluding source files.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 14:21:21 PDT 2018


vsk added a comment.

Thanks for the patch.

Could you please leave out any whitespace, formatting, or grammar changes not related to -ignore-source-regex? It can help to use clang-format-diff.py as a git hook to avoid formatting churn. Also, why does CoverageExporter need to be split out of CoverageExporterJson for this patch? Could it be done as a follow-up instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D43907





More information about the llvm-commits mailing list