[PATCH] D45329: [InstCombine] [NFC] Add more tests for getting rid of select of bittest (D45108, PR36950 / PR17564)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 13:38:23 PDT 2018


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - but see inline comment for an improvement.



================
Comment at: test/Transforms/InstCombine/select-of-bittest.ll:292
+
+define i32 @f_var2(i32, i32) {
+; CHECK-LABEL: @f_var2(
----------------
It's better for readability to give the params and other values names. You can use 'opt -instnamer' to do that.


Repository:
  rL LLVM

https://reviews.llvm.org/D45329





More information about the llvm-commits mailing list