[PATCH] D45320: [MemDep] Fixed handling of invariant.group

[Piotr Padlewski via Phabricator via llvm-commits]

Prazek added a comment.

In https://reviews.llvm.org/D45320#1058698, @dberlin wrote:

> It's kind of hard for me to know what to do with this.
>  The cache invalidation is still very very broken with or without this patch.
>  So this patch is not wrong but everything it does probably needs to be rewritten anyway


I know, I also wish we would get rid of MemDep asap, but as long as it's there, it would be good to avoid weird miscompilations that causes calls to vtable.

In https://reviews.llvm.org/D45320#1058825, @amharc wrote:

> Would handling `NonLocalDefsCache` in the same places as other `DenseMap`s from `Instruction *` be sufficient? In particular, `RemoveCachedNonLocalPointerDependencies`, called by both `removeInstruction` and `invalidateCachedPointerInfo`, looks promising ;)


Yep, this is probably the right way to go


Repository:
  rL LLVM

https://reviews.llvm.org/D45320