[PATCH] D45283: [COFF] Minimal serialization support for precompiled types records

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: test/DebugInfo/precomp.test:10-11
+RUN: llvm-readobj -codeview %t1/precomp.obj | FileCheck %s -check-prefix ENDPRECOMP
+RUN: llvm-pdbutil dump -all %t1/a.obj | FileCheck %s -check-prefix PDB-PRECOMP
+RUN: llvm-pdbutil dump -all %t1/precomp.obj | FileCheck %s -check-prefix PDB-ENDPRECOMP
+
----------------
Can you change this to just `dump -types` instead of `dump -all`?


================
Comment at: test/DebugInfo/precomp.test:29-33
+PDB-PRECOMP:                     Cross Module Exports
+PDB-PRECOMP-NEXT: ============================================================
+PDB-PRECOMP-NEXT: Mod 0000 | `.debug$S`:
+PDB-PRECOMP-NEXT: Showing 0 records
+PDB-PRECOMP-NEXT: 0x1000 | LF_PRECOMP [size = 60] start index = 4096, types count = 1031, signature = 0x1116980E, precomp path = f:\svn\lld\test\coff\precomp\precomp.obj
----------------
You can delete all of this Cross Module Exports stuff as it confuses the user (I originally thought these were XME records).  In a recent patch I added a new header for types that appear in object files, so you can change this to something like:

```
PDB-PRECOMP:         Precompiled Types (.debug$P)
PDB-PRECOMP-NEXT: ============================================================
PDB-PRECOMP-NEXT: Showing 0 records
PDB-PRECOMP-NEXT: 0x1000 | LF_PRECOMP [size = 60] start index = 4096, types count = 1031, signature = 0x1116980E, precomp path = f:\svn\lld\test\coff\precomp\precomp.obj
```


Repository:
  rL LLVM

https://reviews.llvm.org/D45283