[PATCH] D45307: [DWARF v5][NFC] Refactor the implementation of DebugRnglists

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:168
+  while (*OffsetPtr < End) {
+    RangeListEntry Entry{0, 0, 0, 0};
+    if (Error E = Entry.extract(Data, End, OffsetPtr))
----------------
JDevlieghere wrote:
> Maybe we should have a constructor for this?
I had a constructor in an earlier version (before this patch), but Dave suggested to get rid of it in favor of simple braced initializers. I don't have a strong opinion on this but it does seem to me that a constructor would add little value, given that it's really a very simple type, and the braced initializer does the same thing. I also don't anticipate this data structure to be created in lots of other places, where a constructor would provide more safety.

If you don't mind I'd like to keep it that way unless you feel strongly about it.


https://reviews.llvm.org/D45307