[PATCH] D45320: [MemDep] Fixed handling of invariant.group

[Krzysztof Pszeniczny via Phabricator via llvm-commits]

amharc added a comment.

I am not sure that `ValueMap` can be moveable: if it was moved, the `ValueMapT *Map` pointer in `ValueMapCallbackVH` could become invalid.

Wouldn't `std::unique_ptr<ValueMap<Instruction *, NonLocalDepResult>> NonLocalDefsCache` be a better solution?


Repository:
  rL LLVM

https://reviews.llvm.org/D45320