[PATCH] D45287: [InstCombine] Properly change GEP type when reassociating loop invariant GEP chains

Sebastian Pop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 09:44:03 PDT 2018


sebpop accepted this revision.
sebpop added a comment.
This revision is now accepted and ready to land.

Looks good.  Thanks!



================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:1709
+            // -- have to recreate %src & %res
+            auto *SO0 = Src->getOperand(0);
+            Builder.SetInsertPoint(&GEP);
----------------
Let's move SO0 before SO0Ty and use it in that computation.


Repository:
  rL LLVM

https://reviews.llvm.org/D45287





More information about the llvm-commits mailing list