[PATCH] D45108: [InstCombine] Get rid of select of bittest (PR36950 / PR17564)
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 5 09:01:34 PDT 2018
lebedev.ri added a comment.
In https://reviews.llvm.org/D45108#1058593, @spatel wrote:
> In https://reviews.llvm.org/D45108#1058459, @lebedev.ri wrote:
>
> > FIXME: do we want to allow the shift amount to be a value (not a constant), too?
>
>
> You've already coded it to allow that case, right?
Yes, but not intentionally.
> Just remove the m_NonNegative() check and add a test?
Doing that already right now :)
Repository:
rL LLVM
https://reviews.llvm.org/D45108
More information about the llvm-commits
mailing list