[PATCH] D45259: [MC][Tablegen] Allow models to describe the retire control unit for llvm-mca.

Ben Hamilton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 08:51:05 PDT 2018


benhamilton added inline comments.


================
Comment at: llvm/trunk/utils/TableGen/SubtargetEmitter.cpp:616
+    ReorderBufferSize =
+        std::max(ReorderBufferSize, RCU->getValueAsInt("ReorderBufferSize"));
+    MaxRetirePerCycle =
----------------
Looks like this broke the build:

http://green.lab.llvm.org/green//job/clang-stage1-cmake-RA-incremental/47722/consoleFull#-172429723349ba4694-19c4-4d7e-bec5-911270d8a58c

```
/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm/utils/TableGen/SubtargetEmitter.cpp:616:9: error: no matching function for call to 'max'
        std::max(ReorderBufferSize, RCU->getValueAsInt("ReorderBufferSize"));
        ^~~~~~~~
```

P8077


Repository:
  rL LLVM

https://reviews.llvm.org/D45259





More information about the llvm-commits mailing list