[PATCH] D45324: [debug_loc] Fix typo in DWARFExpression constructor
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 5 08:46:54 PDT 2018
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:689
LocDWO.reset(new DWARFDebugLocDWO());
- LocDWO->parse(LocData);
+ // assume all compile units have the same address byte size
+ if (getNumCompileUnits()) {
----------------
LLVM always prefers full sentences:
```// Assume all compile units have the same address byte size.```
================
Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:36
IsLittleEndian, AddressSize);
- DWARFExpression(Extractor, AddressSize, dwarf::DWARF_VERSION).print(OS, MRI);
+ DWARFExpression(Extractor, dwarf::DWARF_VERSION, AddressSize).print(OS, MRI);
}
----------------
Ouch.
Repository:
rL LLVM
https://reviews.llvm.org/D45324
More information about the llvm-commits
mailing list