[PATCH] D45299: API to update MemorySSA for cloned blocks.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added inline comments.


================
Comment at: include/llvm/Analysis/MemorySSA.h:780
+  MemoryUseOrDef *createNewAccess(Instruction *, bool IsKnownDef = false,
+                                  bool IsKnownUse = false);
   MemoryAccess *findDominatingDef(BasicBlock *, enum InsertionPlace);
----------------
dberlin wrote:
> I don't understand the desire here, since it already should correctly identify whether it is a def or use on it's own.
> What are you trying to do?
I'm trying to avoid the additional getModRefInfo call. 

For cloned blocks we have a 1:1 mapping of all instructions. E.g., we know we've just cloned I, with MUD access that's a Use with some defining access. I'm trying to create a MUD for the clone instruction with all that info. The use case is in "CloneUsesAndDefs" below.

Perhaps it's not worth the effort, just trying to avoid AA calls where possible.


Repository:
  rL LLVM

https://reviews.llvm.org/D45299