[PATCH] D45259: [MC][Tablegen] Allow models to describe the retire control unit for llvm-mca.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of minors



================
Comment at: include/llvm/MC/MCSchedule.h:176
+  // micro-ops that can be retired every cycle.
+  unsigned MaxRetirePerCycle;
   const MCRegisterFileDesc *RegisterFiles;
----------------
These comments repeat a lot of what is said in TargetSchedule.td - make the comments briefer here?


================
Comment at: tools/llvm-mca/Dispatch.h:262
 public:
-  DispatchUnit(Backend *B, const llvm::MCSubtargetInfo &STI,
-               const llvm::MCRegisterInfo &MRI, unsigned MicroOpBufferSize,
-               unsigned RegisterFileSize, unsigned MaxDispatchWidth,
-               Scheduler *Sched)
+  DispatchUnit(Backend *B, const llvm::MCSchedModel &SM,
+               const llvm::MCRegisterInfo &MRI, unsigned RegisterFileSize,
----------------
Are you confident that we won't need llvm::MCSubtargetInfo again anytime soon?


https://reviews.llvm.org/D45259