[PATCH] D44400: Fix LLVM IR check lines in utils/update_cc_test_checks.py

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 06:59:19 PDT 2018


RKSimon added a comment.

In https://reviews.llvm.org/D44400#1056172, @MaskRay wrote:

> Regarding test/CodeGen/X86/avx2-intrinsics-x86.ll
>  Several RUN lines share the same `--check-prefix=`. I am not sure the CHECK lines were created by `utils/update_llc_test_checks.py`. It is very likely hand-crafted after applying the tool.


First step - get rid of --x86_extra_scrub entirely so we don't rely on updating the scripts with an optional arg.

@MaskRay Is there any chance you could help here? We need the ret{{[l|q]}} pattern to be used only if that is the only diff between 32/64 bit codegen and it allows us to use a common prefix


Repository:
  rL LLVM

https://reviews.llvm.org/D44400





More information about the llvm-commits mailing list