[PATCH] D45276: Fix a couple of incorrect fields in our generated PDBs.

Chris January via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 06:22:24 PDT 2018


arm-chrjan01 added inline comments.


================
Comment at: lld/COFF/PDB.cpp:1091
   DbiBuilder.setVersionHeader(pdb::PdbDbiV70);
+  DbiBuilder.setMachineType(Config->is64() ? pdb::PDB_Machine::Amd64
+                                           : pdb::PDB_Machine::x86);
----------------
This should use Configuration::Machine rather than Configuration::is64. Configuration::is64 will return true for ARM64, for example, and this condition then goes on to assume it's AMD64.


https://reviews.llvm.org/D45276





More information about the llvm-commits mailing list