[PATCH] D45272: [UpdateTestChecks] Add update_analyze_test_checks.py for cost model analysis generation

Greg Bedwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 05:28:22 PDT 2018


gbedwell added inline comments.


================
Comment at: utils/update_analyze_test_checks.py:69
+  if (opt_basename != "opt"):
+    print >>sys.stderr, 'ERROR: Unexpected opt name: ' + opt_basename
+    sys.exit(1)
----------------
This line won't work in Python 3.  If you want to make it compatible with both you'd probably be best off replacing with a call to sys.stderr.write (and add an explicit newline).  Same goes for the other print statements in the file.


Repository:
  rL LLVM

https://reviews.llvm.org/D45272





More information about the llvm-commits mailing list